Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dataapi] Initialize geth client with address #555

Merged
merged 1 commit into from
May 11, 2024
Merged

[dataapi] Initialize geth client with address #555

merged 1 commit into from
May 11, 2024

Conversation

ian-shim
Copy link
Contributor

Why are these changes needed?

Make sure sender address is passed in when initializing non-private key wallet.

Checks

  • I've made sure the lint is passing in this PR.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

@ian-shim ian-shim requested a review from jianoaix May 10, 2024 23:31
@ian-shim ian-shim closed this May 10, 2024
@ian-shim ian-shim mentioned this pull request May 10, 2024
Merged
5 tasks
@ian-shim ian-shim reopened this May 10, 2024
@ian-shim ian-shim force-pushed the initialize-geth-client-with-addr branch from 066fc19 to 62cf92b Compare May 10, 2024 23:39
@ian-shim ian-shim force-pushed the initialize-geth-client-with-addr branch from 62cf92b to ce9b92b Compare May 10, 2024 23:44
@ian-shim ian-shim merged commit 6f8a083 into Layr-Labs:master May 11, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jianoaix jianoaix jianoaix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ian-shim @jianoaix